ci(eslint): only run circular dependency check on CI #421
Conversation
ghost
requested review from
There was a problem hiding this comment.
Don't we need to set the env variable somewhere, like in a GitHub workflow?
Sorry, I assumed that env var wasn't there because I didn't see any changes for it. But I see we have it already:
ui/.github/workflows/dhis2-verify-lib.yml
Line 14 in 4aaac38
So, these changes look good to me, but I'll let @varl approve (or request changes).
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
That shouldn't even be necessary, the GH actions docs have it listed as always set to true under their default env vars for runner environments. |
Thanks for pointing that out. |
N.p. 👍. That's how I interpret the docs at least. But maybe I'm missing sth. Or the defaults have changed. I'll wait for Viktor's feedback. |
|
🎉 This PR is included in version 6.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This runs our circular dependency checks only on CI, to not slow down editors, as the checks can be very cpu intensive.
See the GH docs for the
CIenv var I'm using: GH actions docs. Besides GH actions,CIis a pretty common env var for indicating that code is running on CI so it should even work with most other providers. See also here: https://github.com/watson/ci-info/blob/master/index.js#L52.Follow up
Also, as a follow up and if this works out, we can move this and related rules to cli-style and make it a rule we check for all our codebases: https://jira.dhis2.org/browse/CLI-19